[Merged by Bors] - Fix skinned mesh normal handling in mesh shader#5095
Closed
edwardvear wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix skinned mesh normal handling in mesh shader#5095edwardvear wants to merge 1 commit intobevyengine:mainfrom
edwardvear wants to merge 1 commit intobevyengine:mainfrom
Conversation
superdump
approved these changes
Jun 25, 2022
Contributor
superdump
left a comment
superdump
left a comment
There was a problem hiding this comment.
Whoops, I must have introduced this when rebasing/reworking one of my pbr refactor prs. Good catch!
mockersf
approved these changes
Jun 25, 2022
Contributor
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 25, 2022
# Objective Update pbr mesh shader to use correct normals for skinned meshes. ## Solution Only use `mesh_normal_local_to_world` for normals if `SKINNED` is not defined.
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective Update pbr mesh shader to use correct normals for skinned meshes. ## Solution Only use `mesh_normal_local_to_world` for normals if `SKINNED` is not defined.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Update pbr mesh shader to use correct normals for skinned meshes. ## Solution Only use `mesh_normal_local_to_world` for normals if `SKINNED` is not defined.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Update pbr mesh shader to use correct normals for skinned meshes. ## Solution Only use `mesh_normal_local_to_world` for normals if `SKINNED` is not defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Update pbr mesh shader to use correct normals for skinned meshes.
Solution
Only use
mesh_normal_local_to_worldfor normals ifSKINNEDis not defined.