[Merged by Bors] - Fix player number in example game in the ecs_guide#5098
Closed
dilyankostov wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix player number in example game in the ecs_guide#5098dilyankostov wants to merge 4 commits intobevyengine:mainfrom
dilyankostov wants to merge 4 commits intobevyengine:mainfrom
Conversation
Currently, if there are 2 players in this example game, the function exclusive_player_system can add a player with the name "Player 2". However, the name should be "Player 3". This PR fixes this. I also add a message to inform that a new player has arrived in the mock game.
alice-i-cecile
added
A-ECS
Nilirad
suggested changes
Jun 26, 2022
Contributor
Nilirad
left a comment
Nilirad
left a comment
There was a problem hiding this comment.
Nice bug busting here. Thanks 😀
I added a comment below with a small correction.
Nilirad
approved these changes
Jun 26, 2022
Member
|
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
# Objective - Small bug in the example game given in examples/ecs/ecs_guide Currently, if there are 2 players in this example game, the function exclusive_player_system can add a player with the name "Player 2". However, the name should be "Player 3". This PR fixes this. I also add a message to inform that a new player has arrived in the mock game. Co-authored-by: Dilyan Kostov <dilyanks@amazon.com>
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - Small bug in the example game given in examples/ecs/ecs_guide Currently, if there are 2 players in this example game, the function exclusive_player_system can add a player with the name "Player 2". However, the name should be "Player 3". This PR fixes this. I also add a message to inform that a new player has arrived in the mock game. Co-authored-by: Dilyan Kostov <dilyanks@amazon.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Small bug in the example game given in examples/ecs/ecs_guide Currently, if there are 2 players in this example game, the function exclusive_player_system can add a player with the name "Player 2". However, the name should be "Player 3". This PR fixes this. I also add a message to inform that a new player has arrived in the mock game. Co-authored-by: Dilyan Kostov <dilyanks@amazon.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Small bug in the example game given in examples/ecs/ecs_guide Currently, if there are 2 players in this example game, the function exclusive_player_system can add a player with the name "Player 2". However, the name should be "Player 3". This PR fixes this. I also add a message to inform that a new player has arrived in the mock game. Co-authored-by: Dilyan Kostov <dilyanks@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently, if there are 2 players in this example game, the function exclusive_player_system can add a player with the name "Player 2". However, the name should be "Player 3". This PR fixes this. I also add a message to inform that a new player has arrived in the mock game.