[Merged by Bors] - remove component and resource suffixes from reflect structs#5219
Closed
oliverpauffley wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - remove component and resource suffixes from reflect structs#5219oliverpauffley wants to merge 2 commits intobevyengine:mainfrom
oliverpauffley wants to merge 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Jul 6, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Looks good to me :) Thanks for the contribution!
Member
|
Can you put the "Fixes" comment into your PR description? That will cause the issue to get linked and automatically closed. |
alice-i-cecile
added
A-ECS
Member
|
Ping @Shatur for review. |
MrGVSV
approved these changes
Jul 6, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
PROMETHIA-27
approved these changes
Jul 6, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
# Objective Remove suffixes from reflect component and resource methods to closer match bevy norms. ## Solution removed suffixes and also fixed a spelling error ---
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…ne#5219) # Objective Remove suffixes from reflect component and resource methods to closer match bevy norms. ## Solution removed suffixes and also fixed a spelling error ---
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…ne#5219) # Objective Remove suffixes from reflect component and resource methods to closer match bevy norms. ## Solution removed suffixes and also fixed a spelling error ---
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ne#5219) # Objective Remove suffixes from reflect component and resource methods to closer match bevy norms. ## Solution removed suffixes and also fixed a spelling error ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remove suffixes from reflect component and resource methods to closer match bevy norms. Fixes #5202
Solution
removed suffixes and also fixed a spelling error