[Merged by Bors] - Rename CameraUi#5234
Closed
nicopap wants to merge 1 commit intobevyengine:mainfrom
Closed
Conversation
alice-i-cecile
added
A-Rendering
nicopap
force-pushed
the
cameraui-clarification
branch
2 times, most recently
from
00aff22 to
aa9593d
Compare
nicopap
force-pushed
the
cameraui-clarification
branch
2 times, most recently
from
bef8285 to
9608cb9
Compare
alice-i-cecile
approved these changes
Jul 7, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I would probably prefer UiCameraConfig, but I won't block on that.
Contributor
Author
|
I much prefer UiCameraConfig |
In bevy 0.7, `CameraUi` was a component specifically added to cameras that display the UI. Since camera-driven rendering was merged, it actually does the opposite! This will make it difficult for current users to adapt to 0.8. To avoid unnecessary confusion, we rename `CameraUi` into `UiCameraConfig`.
nicopap
force-pushed
the
cameraui-clarification
branch
from
9608cb9 to
11d59a1
Compare
alice-i-cecile
added
S-Ready-For-Final-Review
cart
approved these changes
Jul 8, 2022
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
Works for me! Not a huge fan of swapping if let Some(...) = foo {} for if matches!(foo, Some(...)) {}. if let is both more ergonomic and a "built in language feature" instead of a "built in macro". All other things equal, if I ever have the option not to use a macro, I take it.
That being said. Not worth blocking on.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
# Objective In bevy 0.7, `CameraUi` was a component specifically added to cameras that display the UI. Since camera-driven rendering was merged, it actually does the opposite! This will make it difficult for current users to adapt to 0.8. ## Solution To avoid unnecessary confusion, we rename `CameraUi` into `UiCameraConfig`. --- ## Changelog - Rename `CameraUi` to `UiCameraConfig`
Contributor
Contributor
Author
|
@cart I feel |
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective In bevy 0.7, `CameraUi` was a component specifically added to cameras that display the UI. Since camera-driven rendering was merged, it actually does the opposite! This will make it difficult for current users to adapt to 0.8. ## Solution To avoid unnecessary confusion, we rename `CameraUi` into `UiCameraConfig`. --- ## Changelog - Rename `CameraUi` to `UiCameraConfig`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective In bevy 0.7, `CameraUi` was a component specifically added to cameras that display the UI. Since camera-driven rendering was merged, it actually does the opposite! This will make it difficult for current users to adapt to 0.8. ## Solution To avoid unnecessary confusion, we rename `CameraUi` into `UiCameraConfig`. --- ## Changelog - Rename `CameraUi` to `UiCameraConfig`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective In bevy 0.7, `CameraUi` was a component specifically added to cameras that display the UI. Since camera-driven rendering was merged, it actually does the opposite! This will make it difficult for current users to adapt to 0.8. ## Solution To avoid unnecessary confusion, we rename `CameraUi` into `UiCameraConfig`. --- ## Changelog - Rename `CameraUi` to `UiCameraConfig`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In bevy 0.7,
CameraUiwas a component specifically added to camerasthat display the UI. Since camera-driven rendering was merged, it
actually does the opposite! This will make it difficult for current
users to adapt to 0.8.
Solution
To avoid unnecessary confusion, we rename
CameraUiintoUiCameraConfig.Changelog
CameraUitoUiCameraConfig