[Merged by Bors] - TextureFormat::R16Unorm support for Image#5249
Closed
kurtkuehnert wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - TextureFormat::R16Unorm support for Image#5249kurtkuehnert wants to merge 2 commits intobevyengine:mainfrom
kurtkuehnert wants to merge 2 commits intobevyengine:mainfrom
Conversation
Closed
alice-i-cecile
added
A-Rendering
komadori
approved these changes
Jul 8, 2022
mockersf
approved these changes
Jul 8, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
# Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::R16Unorm` format is useful for storing heightmaps. This small change would unblock releasing my terrain plugin on bevy 0.8. ## Solution Added `TextureFormat::R16Unorm` support to Image. This is an alternative (short term solution) to the large texture format issue #4124.
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::R16Unorm` format is useful for storing heightmaps. This small change would unblock releasing my terrain plugin on bevy 0.8. ## Solution Added `TextureFormat::R16Unorm` support to Image. This is an alternative (short term solution) to the large texture format issue bevyengine#4124.
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…r SpecializedComputePipelines (#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to #5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <51823519+Ku95@users.noreply.github.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…r SpecializedComputePipelines (bevyengine#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to bevyengine#5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <51823519+Ku95@users.noreply.github.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::R16Unorm` format is useful for storing heightmaps. This small change would unblock releasing my terrain plugin on bevy 0.8. ## Solution Added `TextureFormat::R16Unorm` support to Image. This is an alternative (short term solution) to the large texture format issue bevyengine#4124.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…r SpecializedComputePipelines (bevyengine#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to bevyengine#5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <51823519+Ku95@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::R16Unorm` format is useful for storing heightmaps. This small change would unblock releasing my terrain plugin on bevy 0.8. ## Solution Added `TextureFormat::R16Unorm` support to Image. This is an alternative (short term solution) to the large texture format issue bevyengine#4124.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…r SpecializedComputePipelines (bevyengine#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to bevyengine#5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <51823519+Ku95@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently some TextureFormats are not supported by the Image type.
The
TextureFormat::R16Unormformat is useful for storing heightmaps.This small change would unblock releasing my terrain plugin on bevy 0.8.
Solution
Added
TextureFormat::R16Unormsupport to Image.This is an alternative (short term solution) to the large texture format issue #4124.