[Merged by Bors] - Added colors to sprite stress test#5317
[Merged by Bors] - Added colors to sprite stress test#5317ManevilleF wants to merge 4 commits intobevyengine:mainfrom
Conversation
|
@superdump This should be enough to test #5247 |
|
How noticeable is the perf difference with this PR? Would it make sense to add colors only under a flag if we want to continue testing rendering without colors? |
|
Oh the performance is terrible, on my computer it jumps from 20 to 10 FPS |
|
I think this should be implemented as a command line option as we will want to test different things. Do you mean that this PR gets 20fps and #5247 with this PR gets 10? Or main vs this PR? |
|
I added the command line option. @superdump what I meant is that on this PR, so basically |
superdump
left a comment
superdump
left a comment
There was a problem hiding this comment.
Minor additional clarification to the purpose of —colored.
Ok, that’s expected. |
|
Now that I think about it we have no way to know how many batches are created since the color tinting is random. So I don't know if this stress test can be useful to test rendering performance as we can stumble upon a very favorable layout or a very unfavorable one which could mess up the test results |
|
In all likelihood there will be many batches. You can see how many draw commands are created. Or after the sort/batch stage, at the beginning of the render stage, see how many phase items there are, I guess. As they get processed into draw commands |
So should I add something or do you think this is this enough ? |
|
I think it’s enough. We should add rendering diagnostics elsewhere. But we should. :) |
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
your color choice seems fitting for today
mockersf
added
A-Rendering
# Objective Allow better performance testing for #5247 ## Solution I added color tints to the `many_sprites` example stress test.
bors
bot
changed the title
# Objective Allow better performance testing for bevyengine#5247 ## Solution I added color tints to the `many_sprites` example stress test.
# Objective Allow better performance testing for bevyengine#5247 ## Solution I added color tints to the `many_sprites` example stress test.
# Objective Allow better performance testing for bevyengine#5247 ## Solution I added color tints to the `many_sprites` example stress test.
3 participants
Objective
Allow better performance testing for #5247
Solution
I added color tints to the
many_spritesexample stress test.