[Merged by Bors] - Add VisibilityBundle and use it to fix gltfs, scenes, and examples#5335
Closed
rparrett wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add VisibilityBundle and use it to fix gltfs, scenes, and examples#5335rparrett wants to merge 2 commits intobevyengine:mainfrom
rparrett wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
approved these changes
Jul 16, 2022
mockersf
added
C-Bug
cart
approved these changes
Jul 16, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2022
…5335) # Objective Gltfs, and a few examples were broken by #5310. Fix em. Closes #5334 ## Solution Add `VisibilityBundle` as described here: #5334 (comment) and sprinkle it around where needed.
Contributor
|
Canceled. |
Contributor
Author
|
Oops. Thought that was a bors failure and not a CI failure in my email inbox, and I snuck in a commit to put |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2022
…5335) # Objective Gltfs, and a few examples were broken by #5310. Fix em. Closes #5334 ## Solution Add `VisibilityBundle` as described here: #5334 (comment) and sprinkle it around where needed.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…evyengine#5335) # Objective Gltfs, and a few examples were broken by bevyengine#5310. Fix em. Closes bevyengine#5334 ## Solution Add `VisibilityBundle` as described here: bevyengine#5334 (comment) and sprinkle it around where needed.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…evyengine#5335) # Objective Gltfs, and a few examples were broken by bevyengine#5310. Fix em. Closes bevyengine#5334 ## Solution Add `VisibilityBundle` as described here: bevyengine#5334 (comment) and sprinkle it around where needed.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…evyengine#5335) # Objective Gltfs, and a few examples were broken by bevyengine#5310. Fix em. Closes bevyengine#5334 ## Solution Add `VisibilityBundle` as described here: bevyengine#5334 (comment) and sprinkle it around where needed.
Contributor
|
I would like to push back on this change, it is not necessary for bevy_scene to depend on bevy_render. See #8136 |
mockersf
pushed a commit
that referenced
this pull request
Apr 3, 2023
# Objective bevy-scene does not have a reason to depend on bevy-render except to include the `Visibility` and `ComputedVisibility` components. Including that in the dependency chain is unnecessary for people not using `bevy_render`. Also fixed a problem where compilation fails when the `serialize` feature was not enabled. ## Solution This was added in #5335 to address some of the problems caused by #5310. Imo the user just always have to remember to include `VisibilityBundle` when they spawn `SceneBundle` or `DynamicSceneBundle`, but that will be a breaking change. This PR makes `bevy_render` an optional dependency of `bevy_scene` instead to respect the existing behavior.
Estus-Dev
pushed a commit
to Estus-Dev/bevy
that referenced
this pull request
Jul 10, 2023
# Objective bevy-scene does not have a reason to depend on bevy-render except to include the `Visibility` and `ComputedVisibility` components. Including that in the dependency chain is unnecessary for people not using `bevy_render`. Also fixed a problem where compilation fails when the `serialize` feature was not enabled. ## Solution This was added in bevyengine#5335 to address some of the problems caused by bevyengine#5310. Imo the user just always have to remember to include `VisibilityBundle` when they spawn `SceneBundle` or `DynamicSceneBundle`, but that will be a breaking change. This PR makes `bevy_render` an optional dependency of `bevy_scene` instead to respect the existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Gltfs, and a few examples were broken by #5310. Fix em.
Closes #5334
Solution
Add
VisibilityBundleas described here: #5334 (comment) and sprinkle it around where needed.