[Merged by Bors] - Remove redundant Size import#5339
Conversation
ghost
added
C-Bug
Member
|
Merging as trivial; this got missed in the rename / migration. bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Size importSize import
ghost
deleted the
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - Fixes bevyengine#5338 - Allow the usage of `use bevy::ui::Size` (see migration guide in bevyengine#4285) ## Solution - Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Fixes bevyengine#5338 - Allow the usage of `use bevy::ui::Size` (see migration guide in bevyengine#4285) ## Solution - Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#5338 - Allow the usage of `use bevy::ui::Size` (see migration guide in bevyengine#4285) ## Solution - Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
use bevy::ui::Size(see migration guide in [Merged by Bors] - MoveSizetobevy_ui#4285)Solution
use crate::Sizeimport so that thepub use geometry::*import also publicly uses theSizestruct.