[Merged by Bors] - Allows conversion of mutable queries to immutable queries#5376
Closed
harudagondi wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Allows conversion of mutable queries to immutable queries#5376harudagondi wants to merge 4 commits intobevyengine:mainfrom
harudagondi wants to merge 4 commits intobevyengine:mainfrom
Conversation
harudagondi
changed the title
BoxyUwU
suggested changes
Jul 19, 2022
alice-i-cecile
added
C-Feature
BoxyUwU
approved these changes
Jul 19, 2022
alice-i-cecile
requested changes
Jul 19, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Some better docs for you, but once those are in this LGTM! I love how easy this was to write.
alice-i-cecile
approved these changes
Jul 19, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
# Objective - Allows conversion of mutable queries to immutable queries. - Fixes #4606 ## Solution - Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly` - `AsRef` is not feasible because creation of new queries is needed. --- ## Changelog ### Added - Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…#5376) # Objective - Allows conversion of mutable queries to immutable queries. - Fixes bevyengine#4606 ## Solution - Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly` - `AsRef` is not feasible because creation of new queries is needed. --- ## Changelog ### Added - Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…#5376) # Objective - Allows conversion of mutable queries to immutable queries. - Fixes bevyengine#4606 ## Solution - Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly` - `AsRef` is not feasible because creation of new queries is needed. --- ## Changelog ### Added - Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…#5376) # Objective - Allows conversion of mutable queries to immutable queries. - Fixes bevyengine#4606 ## Solution - Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly` - `AsRef` is not feasible because creation of new queries is needed. --- ## Changelog ### Added - Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
to_readonlymethod onQuery, which usesQueryState::as_readonlyAsRefis not feasible because creation of new queries is needed.Changelog
Added
Query::to_readonly.