Closed
Conversation
IceSentry
reviewed
Jul 20, 2022
Contributor
IceSentry
left a comment
There was a problem hiding this comment.
Couple of nitpicks, but otherwise I really like this.
mockersf
reviewed
Jul 20, 2022
Co-authored-by: Charles <c.giguere42@gmail.com>
IceSentry
approved these changes
Jul 20, 2022
Contributor
Author
|
bors try |
Contributor
tryBuild failed: |
Contributor
|
I haven't reviewed this deeply, but I don't see anything about tonemapping in this PR. Some of these modes should maybe disable tonemapping, as we want to see the raw output without adjustments. |
Contributor
|
Yeah, tonemapping didn't exist when this PR was created. |
Contributor
|
This appears to have gone stale and perhaps needs significant rewrites. I propose we close this an open an issue for the feature/adoption. |
Contributor
|
Closing as stale, existing issue suffices. Feel free to re-open Rob, this looked really neat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
PbrDebugenum resource covering a bunch of casesPbrDebug::NoneSpecializedMeshPipelinesmesh and vertex layout caches that map from mesh and vertex layouts to specialised render pipelines. This is necessary as thePbrDebuglives outside of and affects all pipelines. Or at least all PBR pipelines, but this was a simple approach.vin thescene_viewertool to cycle through the PBR debug visualisationsNormal-mapped normals:

Changelog
PbrDebugresource to control debug visualizations.