[Merged by Bors] - Revert "Recalculate entity aabbs when meshes change (#4944)"#5489
Closed
cart wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Revert "Recalculate entity aabbs when meshes change (#4944)"#5489cart wants to merge 1 commit intobevyengine:mainfrom
cart wants to merge 1 commit intobevyengine:mainfrom
Conversation
This reverts commit c2b332f.
alice-i-cecile
added
the
C-Performance
alice-i-cecile
approved these changes
Jul 29, 2022
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
# Objective Sadly, #4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](#5423 (comment)) and one that deserves more time than the day we have left before release. ## Solution This reverts commit c2b332f.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
bevyengine#5489) # Objective Sadly, bevyengine#4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](bevyengine#5423 (comment)) and one that deserves more time than the day we have left before release. ## Solution This reverts commit c2b332f.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
bevyengine#5489) # Objective Sadly, bevyengine#4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](bevyengine#5423 (comment)) and one that deserves more time than the day we have left before release. ## Solution This reverts commit c2b332f.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
bevyengine#5489) # Objective Sadly, bevyengine#4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](bevyengine#5423 (comment)) and one that deserves more time than the day we have left before release. ## Solution This reverts commit c2b332f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Sadly, #4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. Handling AABBs properly is a controversial topic and one that deserves more time than the day we have left before release.
Solution
This reverts commit c2b332f.