[Merged by Bors] - Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes #5543#5546
Closed
vertesians wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes #5543#5546vertesians wants to merge 2 commits intobevyengine:mainfrom
vertesians wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
approved these changes
Aug 2, 2022
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Aug 2, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
IceSentry
approved these changes
Aug 3, 2022
Member
|
bors r+ |
Member
|
@mockersf, bors appears to be stuck. |
Member
|
bors r+ |
Member
|
bors r- |
Member
|
Looks like this is stalled out because of the following bors error message: {:error, :create_commit,
"{\"message\":\"Validation Failed\",\"errors\":[{\"resource\":\"author\",\"code\":\"missing_field\",\"field\":\"email\"}],\"documentation_url\":\"https://docs.github.com/rest/reference/git#create-a-commit\"}", |
Member
|
Note that the commit doesn't link to the author's github account / you can't click on the author like you normally could. |
Member
|
@vertesians try setting the author of this commit using the instructions here: https://www.git-tower.com/learn/git/faq/change-author-name-email. |
Member
|
bors r+ |
Member
|
bors r- |
Member
|
I was hoping now that the commit has my authorship attached to it that it would stop failing. Sadly that did not play out. |
vertesians
force-pushed
the
fix-color-add
branch
from
6a01f79 to
38ce90d
Compare
Contributor
Author
|
Really really sorry for the trouble — I didn't even think that it could be an issue. :( Hopefully it'll work now. |
Member
|
bors r+ |
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
inodentry
pushed a commit
to BroovyJammy/bevy
that referenced
this pull request
Aug 19, 2022
…evyengine#5543 (bevyengine#5546) Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543. Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
…evyengine#5543 (bevyengine#5546) Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543. Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…evyengine#5543 (bevyengine#5546) Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543. Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…evyengine#5543 (bevyengine#5546) Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543. Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably a copy-paste error, but
Add<Color>andAddAssign<Color>should userhs.as_hlsa_f32()instead ofrhs.as_linear_rgba_f32()when the LHS is aColor::Hsla. Fixes #5543.