[Merged by Bors] - add some info from ReflectPathError to the error messages#5626
Closed
jakobhellermann wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - add some info from ReflectPathError to the error messages#5626jakobhellermann wants to merge 1 commit intobevyengine:mainfrom
ReflectPathError to the error messages#5626jakobhellermann wants to merge 1 commit intobevyengine:mainfrom
Conversation
nicopap
approved these changes
Aug 9, 2022
Contributor
nicopap
left a comment
nicopap
left a comment
There was a problem hiding this comment.
LGTM.
A note that usually there would also be a list of expected token included, but that change would be more complex.
alice-i-cecile
added
A-Reflection
bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
# Objective - The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name` - it has info for better messages available ## Solution - make the display impl more descriptive by including values from the type
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
# Objective - The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name` - it has info for better messages available ## Solution - make the display impl more descriptive by including values from the type
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ReflectPathError to the error messagesReflectPathError to the error messages
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
…ne#5626) # Objective - The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name` - it has info for better messages available ## Solution - make the display impl more descriptive by including values from the type
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…ne#5626) # Objective - The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name` - it has info for better messages available ## Solution - make the display impl more descriptive by including values from the type
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ne#5626) # Objective - The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name` - it has info for better messages available ## Solution - make the display impl more descriptive by including values from the type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Displayimpl forReflectPathErroris pretty unspecific (e.g.the current struct doesn't have a field with the given nameSolution