[Merged by Bors] - Remove duplicate asserts in test#5648
Closed
BorisBoutillier wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Remove duplicate asserts in test#5648BorisBoutillier wants to merge 1 commit intobevyengine:mainfrom
BorisBoutillier wants to merge 1 commit intobevyengine:mainfrom
Conversation
TimJentzsch
approved these changes
Aug 10, 2022
Contributor
TimJentzsch
left a comment
TimJentzsch
left a comment
There was a problem hiding this comment.
Makes sense to me :)
Weibye
added
S-Ready-For-Final-Review
mockersf
approved these changes
Aug 15, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
# Objective While poking around the hierarchy code, I wondered why some asserts in tests were duplicated. Some git blame later, I found out that commit ( 8eb0440 ) added already existing asserts while removing others. ## Solution Remove the duplicated asserts.
Contributor
|
Build failed: |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
# Objective While poking around the hierarchy code, I wondered why some asserts in tests were duplicated. Some git blame later, I found out that commit ( 8eb0440 ) added already existing asserts while removing others. ## Solution Remove the duplicated asserts.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective While poking around the hierarchy code, I wondered why some asserts in tests were duplicated. Some git blame later, I found out that commit ( bevyengine@8eb0440 ) added already existing asserts while removing others. ## Solution Remove the duplicated asserts.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective While poking around the hierarchy code, I wondered why some asserts in tests were duplicated. Some git blame later, I found out that commit ( bevyengine@8eb0440 ) added already existing asserts while removing others. ## Solution Remove the duplicated asserts.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective While poking around the hierarchy code, I wondered why some asserts in tests were duplicated. Some git blame later, I found out that commit ( bevyengine@8eb0440 ) added already existing asserts while removing others. ## Solution Remove the duplicated asserts.
alice-i-cecile
added
A-ECS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While poking around the hierarchy code, I wondered why some asserts in tests were duplicated.
Some git blame later, I found out that commit ( 8eb0440 ) added already existing asserts while removing others.
Solution
Remove the duplicated asserts.