[Merged by Bors] - insert_attribute panic with full message#5651
Closed
IceSentry wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - insert_attribute panic with full message#5651IceSentry wants to merge 1 commit intobevyengine:mainfrom
IceSentry wants to merge 1 commit intobevyengine:mainfrom
Conversation
IceSentry
added
A-Rendering
Contributor
Author
|
bors try |
Contributor
tryBuild failed: |
Contributor
Author
|
bors try |
Contributor
tim-blackbird
approved these changes
Aug 11, 2022
maccesch
approved these changes
Aug 14, 2022
IceSentry
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Aug 15, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
# Objective When an invalid attribute is inserted and the LogPlugin is not enabled the full error is not printed which means makes it hard to diagnose. ## Solution - Always print the full message in the panic. ## Notes I originally had a separate error log because I wanted to make it clearer for users, but this is probably causing more issues than necessary.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective When an invalid attribute is inserted and the LogPlugin is not enabled the full error is not printed which means makes it hard to diagnose. ## Solution - Always print the full message in the panic. ## Notes I originally had a separate error log because I wanted to make it clearer for users, but this is probably causing more issues than necessary.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective When an invalid attribute is inserted and the LogPlugin is not enabled the full error is not printed which means makes it hard to diagnose. ## Solution - Always print the full message in the panic. ## Notes I originally had a separate error log because I wanted to make it clearer for users, but this is probably causing more issues than necessary.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective When an invalid attribute is inserted and the LogPlugin is not enabled the full error is not printed which means makes it hard to diagnose. ## Solution - Always print the full message in the panic. ## Notes I originally had a separate error log because I wanted to make it clearer for users, but this is probably causing more issues than necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When an invalid attribute is inserted and the LogPlugin is not enabled the full error is not printed which means makes it hard to diagnose.
Solution
Notes
I originally had a separate error log because I wanted to make it clearer for users, but this is probably causing more issues than necessary.