[Merged by Bors] - Use circle for breakout example#5657
Closed
tkgalk wants to merge 3 commits intobevyengine:mainfrom
tkgalk:use-circle-for-breakout-example
Closed
[Merged by Bors] - Use circle for breakout example#5657tkgalk wants to merge 3 commits intobevyengine:mainfrom tkgalk:use-circle-for-breakout-example
tkgalk wants to merge 3 commits intobevyengine:mainfrom
tkgalk:use-circle-for-breakout-example
Conversation
alice-i-cecile
added
A-Rendering
Contributor
Author
|
Seems that I made the branch from |
Contributor
Author
|
Oh, it is rebased on |
mockersf
approved these changes
Aug 13, 2022
NiklasEi
approved these changes
Aug 13, 2022
NiklasEi
added
the
S-Ready-For-Final-Review
IceSentry
approved these changes
Aug 16, 2022
Member
|
bors r+ |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
# Objective - Replace the square with a circle in the breakout example. - Fixes #4324, adopted from #4682 by @shaderduck. ## Solution - Uses the Mesh2D APIs to draw a circle. The collision still uses the AABB algorithm, but it seems to be working fine, and I haven't seen any odd looking cases.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective - Replace the square with a circle in the breakout example. - Fixes bevyengine#4324, adopted from bevyengine#4682 by @shaderduck. ## Solution - Uses the Mesh2D APIs to draw a circle. The collision still uses the AABB algorithm, but it seems to be working fine, and I haven't seen any odd looking cases.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Replace the square with a circle in the breakout example. - Fixes bevyengine#4324, adopted from bevyengine#4682 by @shaderduck. ## Solution - Uses the Mesh2D APIs to draw a circle. The collision still uses the AABB algorithm, but it seems to be working fine, and I haven't seen any odd looking cases.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Replace the square with a circle in the breakout example. - Fixes bevyengine#4324, adopted from bevyengine#4682 by @shaderduck. ## Solution - Uses the Mesh2D APIs to draw a circle. The collision still uses the AABB algorithm, but it seems to be working fine, and I haven't seen any odd looking cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution