[Merged by Bors] - Remove an outdated workaround for impl Trait#5659
Closed
joseph-gio wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Remove an outdated workaround for impl Trait#5659joseph-gio wants to merge 2 commits intobevyengine:mainfrom
impl Trait#5659joseph-gio wants to merge 2 commits intobevyengine:mainfrom
Conversation
BorisBoutillier
approved these changes
Aug 12, 2022
Contributor
BorisBoutillier
left a comment
BorisBoutillier
left a comment
There was a problem hiding this comment.
Double checked we have no additional reference to get_stage/get_stage_mut in bevy source code then the one updated.
rparrett
added
C-Code-Quality
Contributor
|
@JoJoJet If you rebase/merge the latest |
Member
Author
|
@TimJentzsch Thanks! I appreciate it |
joseph-gio
force-pushed
the
impl-trait-arg
branch
from
b2371f1 to
530d951
Compare
NiklasEi
approved these changes
Aug 13, 2022
NiklasEi
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
# Objective Rust 1.63 resolved [an issue](rust-lang/rust#83701) that prevents you from combining explicit generic arguments with `impl Trait` arguments. Now, we no longer need to use dynamic dispatch to work around this. ## Migration Guide The methods `Schedule::get_stage` and `get_stage_mut` now accept `impl StageLabel` instead of `&dyn StageLabel`. ### Before ```rust let stage = schedule.get_stage_mut::<SystemStage>(&MyLabel)?; ``` ### After ```rust let stage = schedule.get_stage_mut::<SystemStage>(MyLabel)?; ```
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
# Objective Rust 1.63 resolved [an issue](rust-lang/rust#83701) that prevents you from combining explicit generic arguments with `impl Trait` arguments. Now, we no longer need to use dynamic dispatch to work around this. ## Migration Guide The methods `Schedule::get_stage` and `get_stage_mut` now accept `impl StageLabel` instead of `&dyn StageLabel`. ### Before ```rust let stage = schedule.get_stage_mut::<SystemStage>(&MyLabel)?; ``` ### After ```rust let stage = schedule.get_stage_mut::<SystemStage>(MyLabel)?; ```
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
impl Traitimpl Trait
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective Rust 1.63 resolved [an issue](rust-lang/rust#83701) that prevents you from combining explicit generic arguments with `impl Trait` arguments. Now, we no longer need to use dynamic dispatch to work around this. ## Migration Guide The methods `Schedule::get_stage` and `get_stage_mut` now accept `impl StageLabel` instead of `&dyn StageLabel`. ### Before ```rust let stage = schedule.get_stage_mut::<SystemStage>(&MyLabel)?; ``` ### After ```rust let stage = schedule.get_stage_mut::<SystemStage>(MyLabel)?; ```
rparrett
added
the
M-Migration-Guide
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Rust 1.63 resolved [an issue](rust-lang/rust#83701) that prevents you from combining explicit generic arguments with `impl Trait` arguments. Now, we no longer need to use dynamic dispatch to work around this. ## Migration Guide The methods `Schedule::get_stage` and `get_stage_mut` now accept `impl StageLabel` instead of `&dyn StageLabel`. ### Before ```rust let stage = schedule.get_stage_mut::<SystemStage>(&MyLabel)?; ``` ### After ```rust let stage = schedule.get_stage_mut::<SystemStage>(MyLabel)?; ```
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Rust 1.63 resolved [an issue](rust-lang/rust#83701) that prevents you from combining explicit generic arguments with `impl Trait` arguments. Now, we no longer need to use dynamic dispatch to work around this. ## Migration Guide The methods `Schedule::get_stage` and `get_stage_mut` now accept `impl StageLabel` instead of `&dyn StageLabel`. ### Before ```rust let stage = schedule.get_stage_mut::<SystemStage>(&MyLabel)?; ``` ### After ```rust let stage = schedule.get_stage_mut::<SystemStage>(MyLabel)?; ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Rust 1.63 resolved an issue that prevents you from combining explicit generic arguments with
impl Traitarguments.Now, we no longer need to use dynamic dispatch to work around this.
Migration Guide
The methods
Schedule::get_stageandget_stage_mutnow acceptimpl StageLabelinstead of&dyn StageLabel.Before
After