[Merged by Bors] - register Cow<'static, str> for reflection#5664
Closed
maccesch wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - register Cow<'static, str> for reflection#5664maccesch wants to merge 1 commit intobevyengine:mainfrom
Cow<'static, str> for reflection#5664maccesch wants to merge 1 commit intobevyengine:mainfrom
Conversation
maccesch
changed the title
Cow<'static, str> for reflection
Contributor
Author
|
@alice-i-cecile Weirdly the check that is failing is not at all connected to my code! |
MrGVSV
approved these changes
Aug 13, 2022
BorisBoutillier
approved these changes
Aug 13, 2022
Contributor
BorisBoutillier
left a comment
BorisBoutillier
left a comment
There was a problem hiding this comment.
CI faliure is unrelated to this PR ( we need to merge #5665 first to fix CI).
Weibye
added
S-Ready-For-Final-Review
mockersf
approved these changes
Aug 13, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
# Objective Fixes #5597 ## Solution Registered type at suggested place.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Cow<'static, str> for reflectionCow<'static, str> for reflection
inodentry
pushed a commit
to BroovyJammy/bevy
that referenced
this pull request
Aug 19, 2022
# Objective Fixes bevyengine#5597 ## Solution Registered type at suggested place.
maccesch
added a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective Fixes bevyengine#5597 ## Solution Registered type at suggested place.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#5597 ## Solution Registered type at suggested place.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#5597 ## Solution Registered type at suggested place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5597
Solution
Registered type at suggested place.