[Merged by Bors] - Use latest stable version for CI 'build' job#5672
Closed
TimJentzsch wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Use latest stable version for CI 'build' job#5672TimJentzsch wants to merge 1 commit intobevyengine:mainfrom
TimJentzsch wants to merge 1 commit intobevyengine:mainfrom
Conversation
The CI 'build' job now uses actions-rs/toolchain@v1 to use the latest stable version of Rust. Previously this depended on the default Rust version defined on the Ubuntu image.
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Aug 13, 2022
alice-i-cecile
added
the
P-High
mockersf
approved these changes
Aug 13, 2022
mockersf
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2022
# Objective Fixes #5668. The Rust version used in the CI `build` step previously depended on the default Rust version defined by GitHub in the Ubuntu image: <https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-tools> This currently doesn't allow us to use Rust 1.63 features until this version is updated. ## Solution We now use the `actions-rs/toolchain@v1` action to always use the latest stable Rust version. This is already used for other CI jobs that we have.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective Fixes bevyengine#5668. The Rust version used in the CI `build` step previously depended on the default Rust version defined by GitHub in the Ubuntu image: <https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-tools> This currently doesn't allow us to use Rust 1.63 features until this version is updated. ## Solution We now use the `actions-rs/toolchain@v1` action to always use the latest stable Rust version. This is already used for other CI jobs that we have.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#5668. The Rust version used in the CI `build` step previously depended on the default Rust version defined by GitHub in the Ubuntu image: <https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-tools> This currently doesn't allow us to use Rust 1.63 features until this version is updated. ## Solution We now use the `actions-rs/toolchain@v1` action to always use the latest stable Rust version. This is already used for other CI jobs that we have.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#5668. The Rust version used in the CI `build` step previously depended on the default Rust version defined by GitHub in the Ubuntu image: <https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-tools> This currently doesn't allow us to use Rust 1.63 features until this version is updated. ## Solution We now use the `actions-rs/toolchain@v1` action to always use the latest stable Rust version. This is already used for other CI jobs that we have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5668.
The Rust version used in the CI
buildstep previously depended on the default Rust version defined by GitHub in the Ubuntu image: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-toolsThis currently doesn't allow us to use Rust 1.63 features until this version is updated.
Solution
We now use the
actions-rs/toolchain@v1action to always use the latest stable Rust version.This is already used for other CI jobs that we have.