[Merged by Bors] - Rework manual event iterator so we can actually name the type#5735
Closed
Aceeri wants to merge 13 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Rework manual event iterator so we can actually name the type#5735Aceeri wants to merge 13 commits intobevyengine:mainfrom
Aceeri wants to merge 13 commits intobevyengine:mainfrom
Conversation
afonsolage
approved these changes
Aug 21, 2022
cart
reviewed
Aug 30, 2022
alice-i-cecile
added
the
C-Usability
Aceeri
force-pushed
the
manual-event-iterator
branch
from
ed9c4a4 to
df18953
Compare
joseph-gio
approved these changes
Dec 22, 2022
Member
joseph-gio
left a comment
joseph-gio
left a comment
There was a problem hiding this comment.
Everything here looks good to me.
In the future, I think we should consider renaming .iter(). It always feels wrong and surprising that events.iter() mutates events, and it's especially surprising that for _ in &events does not work. Borrowing from std::io::Read, I think a potentially better name for that method would be .read().
Member
Author
|
I think it somewhat makes sense in that events is basically a saved iterator, we aren't actually mutating |
Member
|
Mutating |
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Dec 24, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Can you add the little utility methods (get_events and friends) to the change log too? They're quite useful, but easy to overlook.
bors r+
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective - Be able to name the type that `ManualEventReader::iter/iter_with_id` returns and `EventReader::iter/iter_with_id` by proxy. Currently for the purpose of #5719 ## Solution - Create a custom `Iterator` type.
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective - Be able to name the type that `ManualEventReader::iter/iter_with_id` returns and `EventReader::iter/iter_with_id` by proxy. Currently for the purpose of #5719 ## Solution - Create a custom `Iterator` type.
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective - Be able to name the type that `ManualEventReader::iter/iter_with_id` returns and `EventReader::iter/iter_with_id` by proxy. Currently for the purpose of #5719 ## Solution - Create a custom `Iterator` type.
Contributor
bors
bot
changed the title
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
…gine#5735) # Objective - Be able to name the type that `ManualEventReader::iter/iter_with_id` returns and `EventReader::iter/iter_with_id` by proxy. Currently for the purpose of bevyengine#5719 ## Solution - Create a custom `Iterator` type.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…gine#5735) # Objective - Be able to name the type that `ManualEventReader::iter/iter_with_id` returns and `EventReader::iter/iter_with_id` by proxy. Currently for the purpose of bevyengine#5719 ## Solution - Create a custom `Iterator` type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
ManualEventReader::iter/iter_with_idreturns andEventReader::iter/iter_with_idby proxy.Currently for the purpose of Add
IntoIteratorto &mut EventReader #5719Solution
Iteratortype.Changelog
oldest_idandget_eventconvenience methods added toEvents<T>.