Skip to content

[Merged by Bors] - fixes the types for Vec3 and Quat in scene example to remove WARN from the logs#5751

Closed
tkgalk wants to merge 1 commit intobevyengine:mainfrom
tkgalk:fix-scene-example-warning
Closed

[Merged by Bors] - fixes the types for Vec3 and Quat in scene example to remove WARN from the logs#5751
tkgalk wants to merge 1 commit intobevyengine:mainfrom
tkgalk:fix-scene-example-warning

Conversation

@tkgalk
Copy link
Contributor

@tkgalk tkgalk commented Aug 20, 2022

Objective

Solution

  • Changes the Vec3 and Quat types.

@MrGVSV MrGVSV added C-Examples An addition or correction to our examples A-Scenes Serialized ECS data stored on the disk labels Aug 20, 2022
@Weibye Weibye added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 20, 2022
Copy link
Contributor

@Carter0 Carter0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cart
Copy link
Member

cart commented Aug 20, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 20, 2022
…m the logs (#5751)

# Objective
- Fixes #5745.

## Solution
- Changes the Vec3 and Quat types.
@bors
Copy link
Contributor

bors bot commented Aug 20, 2022

@bors bors bot changed the title fixes the types for Vec3 and Quat in scene example to remove WARN from the logs [Merged by Bors] - fixes the types for Vec3 and Quat in scene example to remove WARN from the logs Aug 20, 2022
@bors bors bot closed this Aug 20, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
…m the logs (bevyengine#5751)

# Objective
- Fixes bevyengine#5745.

## Solution
- Changes the Vec3 and Quat types.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…m the logs (bevyengine#5751)

# Objective
- Fixes bevyengine#5745.

## Solution
- Changes the Vec3 and Quat types.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…m the logs (bevyengine#5751)

# Objective
- Fixes bevyengine#5745.

## Solution
- Changes the Vec3 and Quat types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Scenes Serialized ECS data stored on the disk C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scenes Example isn't Recognizing Vec3 Type

6 participants