[Merged by Bors] - update camera projection if viewport changed#5945
Closed
jakobhellermann wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - update camera projection if viewport changed#5945jakobhellermann wants to merge 4 commits intobevyengine:mainfrom
jakobhellermann wants to merge 4 commits intobevyengine:mainfrom
Conversation
jakobhellermann
added
C-Bug
superdump
requested changes
Sep 15, 2022
jakobhellermann
force-pushed
the
fix-camera-viewport-projection
branch
from
2e1c201 to
f2e046e
Compare
Contributor
Author
|
rebased an addressed review comments |
tim-blackbird
approved these changes
Oct 28, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
fixes #5944 Uses the second solution: > 2. keep track of the old viewport in the computed_state, and if camera.viewport != camera.computed_state.old_viewport, then update the projection. This is more reliable, but needs to store two UVec2s more in the camera (probably not a big deal).
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
fixes bevyengine#5944 Uses the second solution: > 2. keep track of the old viewport in the computed_state, and if camera.viewport != camera.computed_state.old_viewport, then update the projection. This is more reliable, but needs to store two UVec2s more in the camera (probably not a big deal).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5944
Uses the second solution: