[Merged by Bors] - Add a Gamepad Viewer tool to examples#6074
Closed
rparrett wants to merge 7 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add a Gamepad Viewer tool to examples#6074rparrett wants to merge 7 commits intobevyengine:mainfrom
rparrett wants to merge 7 commits intobevyengine:mainfrom
Conversation
Nilirad
added
C-Examples
Contributor
There was a problem hiding this comment.
This is a really good tool/example to trouble check gamepads, and also see some more advanced code interacting with the GamePad, even if 'boring'.
But I think it would better fit as tools/gamepad_viewer.rs rather than a input/gamepad_demo.rs
I have proposed a different set of colors, that I found more appealing, but that is really subjective.
Comment on lines
+22
to
+27
| const NORMAL_BUTTON_COLOR: Color = Color::rgb(0.2, 0.2, 0.2); | ||
| const ACTIVE_BUTTON_COLOR: Color = Color::PURPLE; | ||
| const LIVE_COLOR: Color = Color::rgb(0.4, 0.4, 0.4); | ||
| const DEAD_COLOR: Color = Color::rgb(0.3, 0.3, 0.3); | ||
| const EXTENT_COLOR: Color = Color::rgb(0.3, 0.3, 0.3); | ||
| const TEXT_COLOR: Color = Color::WHITE; |
Contributor
There was a problem hiding this comment.
I have tried a simpler set of color (associated with a ClearColor(Color::BLACK)
const NORMAL_BUTTON_COLOR: Color = Color::GRAY;
const ACTIVE_BUTTON_COLOR: Color = Color::DARK_GREEN;
const LIVE_COLOR: Color = Color::BLACK;
const DEAD_COLOR: Color = Color::MAROON;
const EXTENT_COLOR: Color = Color::MAROON;
const TEXT_COLOR: Color = Color::WHITE;
Contributor
Author
There was a problem hiding this comment.
I'm open to alternate color schemes. I feel like it would be best to match existing examples, especially with the bevy examples page on the website though.
I'm curious to hear other opinions about this, but the proposed set looks a little out of place on the website to me, and the contrast between full-white text and full-black background seems a bit intense.
Contributor
There was a problem hiding this comment.
Yeah, I'd prefer keeping the default bevy clear color and use colors similar to other examples
BorisBoutillier
approved these changes
Sep 23, 2022
rparrett
force-pushed
the
gamepad-demo
branch
from
76fe3a5 to
285947e
Compare
rparrett
changed the title
IceSentry
approved these changes
Sep 24, 2022
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
You could update to the new spawn that replaces spawn_bundle but other than that, code looks good. It's a lot of code, but the examples in tools/ are intended to be a bit more advanced, so I think that's good.
rparrett
force-pushed
the
gamepad-demo
branch
from
285947e to
f0085a7
Compare
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Sep 24, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Excellent work; we can refine this further as we go.
bors r+
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2022
# Objective Give folks an easy way to test their gamepad with bevy. ~~This is a lot of very boring code for an example. Maybe it belongs in the "tools" directory?~~ ## Solution https://user-images.githubusercontent.com/200550/191884342-ace213c0-b423-449a-9295-530cbceaa19e.mp4 ## Notes This has brought to light (to me, anyway) some fairly major issues with gamepads on the web. See: [WASM mappings (gilrs issue 107)](https://gitlab.com/gilrs-project/gilrs/-/issues/107) [Inaccurate value for trigger button of Xbox gamepad with WASM (gilrs issue 121)](https://gitlab.com/gilrs-project/gilrs/-/issues/121)
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2022
# Objective Give folks an easy way to test their gamepad with bevy. ~~This is a lot of very boring code for an example. Maybe it belongs in the "tools" directory?~~ ## Solution https://user-images.githubusercontent.com/200550/191884342-ace213c0-b423-449a-9295-530cbceaa19e.mp4 ## Notes This has brought to light (to me, anyway) some fairly major issues with gamepads on the web. See: [WASM mappings (gilrs issue 107)](https://gitlab.com/gilrs-project/gilrs/-/issues/107) [Inaccurate value for trigger button of Xbox gamepad with WASM (gilrs issue 121)](https://gitlab.com/gilrs-project/gilrs/-/issues/121)
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective Give folks an easy way to test their gamepad with bevy. ~~This is a lot of very boring code for an example. Maybe it belongs in the "tools" directory?~~ ## Solution https://user-images.githubusercontent.com/200550/191884342-ace213c0-b423-449a-9295-530cbceaa19e.mp4 ## Notes This has brought to light (to me, anyway) some fairly major issues with gamepads on the web. See: [WASM mappings (gilrs issue 107)](https://gitlab.com/gilrs-project/gilrs/-/issues/107) [Inaccurate value for trigger button of Xbox gamepad with WASM (gilrs issue 121)](https://gitlab.com/gilrs-project/gilrs/-/issues/121)
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Give folks an easy way to test their gamepad with bevy. ~~This is a lot of very boring code for an example. Maybe it belongs in the "tools" directory?~~ ## Solution https://user-images.githubusercontent.com/200550/191884342-ace213c0-b423-449a-9295-530cbceaa19e.mp4 ## Notes This has brought to light (to me, anyway) some fairly major issues with gamepads on the web. See: [WASM mappings (gilrs issue 107)](https://gitlab.com/gilrs-project/gilrs/-/issues/107) [Inaccurate value for trigger button of Xbox gamepad with WASM (gilrs issue 121)](https://gitlab.com/gilrs-project/gilrs/-/issues/121)
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Give folks an easy way to test their gamepad with bevy. ~~This is a lot of very boring code for an example. Maybe it belongs in the "tools" directory?~~ ## Solution https://user-images.githubusercontent.com/200550/191884342-ace213c0-b423-449a-9295-530cbceaa19e.mp4 ## Notes This has brought to light (to me, anyway) some fairly major issues with gamepads on the web. See: [WASM mappings (gilrs issue 107)](https://gitlab.com/gilrs-project/gilrs/-/issues/107) [Inaccurate value for trigger button of Xbox gamepad with WASM (gilrs issue 121)](https://gitlab.com/gilrs-project/gilrs/-/issues/121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Give folks an easy way to test their gamepad with bevy.
This is a lot of very boring code for an example. Maybe it belongs in the "tools" directory?Solution
gamepad_demo.mp4
Notes
This has brought to light (to me, anyway) some fairly major issues with gamepads on the web. See:
WASM mappings (gilrs issue 107)
Inaccurate value for trigger button of Xbox gamepad with WASM (gilrs issue 121)