[Merged by Bors] - doc: document PerspectiveProjection#6310
Closed
dataphract wants to merge 3 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - doc: document PerspectiveProjection#6310dataphract wants to merge 3 commits intobevyengine:mainfrom
PerspectiveProjection#6310dataphract wants to merge 3 commits intobevyengine:mainfrom
Conversation
dataphract
added
C-Docs
james7132
requested changes
Oct 19, 2022
james7132
approved these changes
Oct 20, 2022
Member
|
You add the defaults to the documentation. Is there an easy way to ensure those remains in sync? |
Member
Author
Nothing automatic to my knowledge, but I wouldn't expect these defaults to change often. |
rparrett
reviewed
Oct 20, 2022
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
I think some lines breaks would help with readability when rendered.
IMO, exposing these defaults to users is worth the overhead of maintaining the docs.
- insert additional line breaks - provide default vertical FOV value in both radians and degrees Co-authored-by: Rob Parrett <robparrett@gmail.com>
rparrett
approved these changes
Oct 20, 2022
james7132
added
the
S-Ready-For-Final-Review
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
These are fantastic, great work.
bors r+
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
# Objective Fixes #6279. ## Solution Added documentation explaining the meanings and default values of `PerspectiveProjection`'s fields. Co-authored-by: dataphract <86984145+dataphract@users.noreply.github.com>
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
# Objective Fixes #6279. ## Solution Added documentation explaining the meanings and default values of `PerspectiveProjection`'s fields. Co-authored-by: dataphract <86984145+dataphract@users.noreply.github.com>
Contributor
bors
bot
changed the title
PerspectiveProjectionPerspectiveProjection
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#6279. ## Solution Added documentation explaining the meanings and default values of `PerspectiveProjection`'s fields. Co-authored-by: dataphract <86984145+dataphract@users.noreply.github.com>
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective Fixes bevyengine#6279. ## Solution Added documentation explaining the meanings and default values of `PerspectiveProjection`'s fields. Co-authored-by: dataphract <86984145+dataphract@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#6279. ## Solution Added documentation explaining the meanings and default values of `PerspectiveProjection`'s fields. Co-authored-by: dataphract <86984145+dataphract@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6279.
Solution
Added documentation explaining the meanings and default values of
PerspectiveProjection's fields.