[Merged by Bors] - document insert_non_send_resource panics#6328
Closed
lovelymono wants to merge 4 commits intobevyengine:mainfrom
lovelymono:insert_non_send_resource-document-panics
Closed
[Merged by Bors] - document insert_non_send_resource panics#6328lovelymono wants to merge 4 commits intobevyengine:mainfrom lovelymono:insert_non_send_resource-document-panics
lovelymono wants to merge 4 commits intobevyengine:mainfrom
lovelymono:insert_non_send_resource-document-panics
Conversation
Signed-off-by: Lena Milizé <me@lvmn.org>
Co-authored-by: ira <JustTheCoolDude@gmail.com>
alice-i-cecile
approved these changes
Oct 21, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Thanks! Merging as trivial.
bors r+
alice-i-cecile
added
C-Docs
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Lena Milizé <me@lvmn.org> # Objective Fixes #6277. ## Solution Adds `# Panics` section to [`fn insert_non_send_resource`](http://dev-docs.bevyengine.org/bevy/ecs/world/struct.World.html#method.insert_non_send_resource) documentation, which explains that it panics when called from thread other than main thread.
Contributor
|
|
Member
|
bors r- |
Contributor
|
Canceled. |
tim-blackbird
approved these changes
Oct 21, 2022
mockersf
reviewed
Oct 21, 2022
Co-authored-by: François <mockersf@gmail.com>
Co-authored-by: Mike <mike.hsu@gmail.com>
mockersf
approved these changes
Oct 21, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Lena Milizé <me@lvmn.org> # Objective Fixes #6277. ## Solution Adds `# Panics` section to [`fn insert_non_send_resource`](http://dev-docs.bevyengine.org/bevy/ecs/world/struct.World.html#method.insert_non_send_resource) documentation, which explains that it panics when called from thread other than main thread.
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Lena Milizé <me@lvmn.org> # Objective Fixes #6277. ## Solution Adds `# Panics` section to [`fn insert_non_send_resource`](http://dev-docs.bevyengine.org/bevy/ecs/world/struct.World.html#method.insert_non_send_resource) documentation, which explains that it panics when called from thread other than main thread.
Contributor
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Lena Milizé <me@lvmn.org> # Objective Fixes bevyengine#6277. ## Solution Adds `# Panics` section to [`fn insert_non_send_resource`](http://dev-docs.bevyengine.org/bevy/ecs/world/struct.World.html#method.insert_non_send_resource) documentation, which explains that it panics when called from thread other than main thread.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
Signed-off-by: Lena Milizé <me@lvmn.org> # Objective Fixes bevyengine#6277. ## Solution Adds `# Panics` section to [`fn insert_non_send_resource`](http://dev-docs.bevyengine.org/bevy/ecs/world/struct.World.html#method.insert_non_send_resource) documentation, which explains that it panics when called from thread other than main thread.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Lena Milizé <me@lvmn.org> # Objective Fixes bevyengine#6277. ## Solution Adds `# Panics` section to [`fn insert_non_send_resource`](http://dev-docs.bevyengine.org/bevy/ecs/world/struct.World.html#method.insert_non_send_resource) documentation, which explains that it panics when called from thread other than main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lena Milizé me@lvmn.org
Objective
Fixes #6277.
Solution
Adds
# Panicssection tofn insert_non_send_resourcedocumentation, which explains that it panics when called from thread other than main thread.