[Merged by Bors] - Fix outdated and badly formatted docs for WindowDescriptor::transparent#6329
[Merged by Bors] - Fix outdated and badly formatted docs for WindowDescriptor::transparent#6329rparrett wants to merge 3 commits intobevyengine:mainfrom
WindowDescriptor::transparent#6329Conversation
|
it works on macOS if I change bevy/crates/bevy_render/src/view/window.rs Line 199 in abbc0cf CompositeAlphaMode::PostMultiplied
|
hymm
left a comment
There was a problem hiding this comment.
Approving just the windows 11 related changes here. I can't test macOS.
What would you suggest we do with this documentation of MacOS users? Should we create a bevy issue that documents the workaround and links to the wgpu issue and then link to that? |
|
Running the |
Thanks. I think that's normal, as that example also disables the title bar. |
Yeah, new issue sounds good 👍 |
|
Alright, now linking off to the linux and mac specific bevy issues. |
|
bors r+ |
…ent` (#6329) # Objective See title ## Before / After <img width="988" alt="Screen Shot 2022-10-21 at 10 51 12 AM" src="https://user-images.githubusercontent.com/200550/197258517-29fec3e0-e272-4ab1-9f4c-c646b04876f2.png"> <img width="988" alt="Screen Shot 2022-10-21 at 10 51 24 AM" src="https://user-images.githubusercontent.com/200550/197258519-7fbaf058-fc2c-469e-ae34-5531f02a632f.png"> ## Open questions ~~The old docs previously linked to a winit but that was preventing transparency for working on Windows 11. The recent winit upgrade should have fixed this.~~ ~~I'm unable to test on Windows 11 though, so someone should verify that we no longer need to call this out as being broken.~~ edit: Seems like we're good on Windows 11, thanks.
|
Build failed (retrying...): |
…ent` (#6329) # Objective See title ## Before / After <img width="988" alt="Screen Shot 2022-10-21 at 10 51 12 AM" src="https://user-images.githubusercontent.com/200550/197258517-29fec3e0-e272-4ab1-9f4c-c646b04876f2.png"> <img width="988" alt="Screen Shot 2022-10-21 at 10 51 24 AM" src="https://user-images.githubusercontent.com/200550/197258519-7fbaf058-fc2c-469e-ae34-5531f02a632f.png"> ## Open questions ~~The old docs previously linked to a winit but that was preventing transparency for working on Windows 11. The recent winit upgrade should have fixed this.~~ ~~I'm unable to test on Windows 11 though, so someone should verify that we no longer need to call this out as being broken.~~ edit: Seems like we're good on Windows 11, thanks.
WindowDescriptor::transparentWindowDescriptor::transparent
…ent` (bevyengine#6329) # Objective See title ## Before / After <img width="988" alt="Screen Shot 2022-10-21 at 10 51 12 AM" src="https://user-images.githubusercontent.com/200550/197258517-29fec3e0-e272-4ab1-9f4c-c646b04876f2.png"> <img width="988" alt="Screen Shot 2022-10-21 at 10 51 24 AM" src="https://user-images.githubusercontent.com/200550/197258519-7fbaf058-fc2c-469e-ae34-5531f02a632f.png"> ## Open questions ~~The old docs previously linked to a winit but that was preventing transparency for working on Windows 11. The recent winit upgrade should have fixed this.~~ ~~I'm unable to test on Windows 11 though, so someone should verify that we no longer need to call this out as being broken.~~ edit: Seems like we're good on Windows 11, thanks.
…ent` (bevyengine#6329) # Objective See title ## Before / After <img width="988" alt="Screen Shot 2022-10-21 at 10 51 12 AM" src="https://user-images.githubusercontent.com/200550/197258517-29fec3e0-e272-4ab1-9f4c-c646b04876f2.png"> <img width="988" alt="Screen Shot 2022-10-21 at 10 51 24 AM" src="https://user-images.githubusercontent.com/200550/197258519-7fbaf058-fc2c-469e-ae34-5531f02a632f.png"> ## Open questions ~~The old docs previously linked to a winit but that was preventing transparency for working on Windows 11. The recent winit upgrade should have fixed this.~~ ~~I'm unable to test on Windows 11 though, so someone should verify that we no longer need to call this out as being broken.~~ edit: Seems like we're good on Windows 11, thanks.
…ent` (bevyengine#6329) # Objective See title ## Before / After <img width="988" alt="Screen Shot 2022-10-21 at 10 51 12 AM" src="https://user-images.githubusercontent.com/200550/197258517-29fec3e0-e272-4ab1-9f4c-c646b04876f2.png"> <img width="988" alt="Screen Shot 2022-10-21 at 10 51 24 AM" src="https://user-images.githubusercontent.com/200550/197258519-7fbaf058-fc2c-469e-ae34-5531f02a632f.png"> ## Open questions ~~The old docs previously linked to a winit but that was preventing transparency for working on Windows 11. The recent winit upgrade should have fixed this.~~ ~~I'm unable to test on Windows 11 though, so someone should verify that we no longer need to call this out as being broken.~~ edit: Seems like we're good on Windows 11, thanks.

Objective
See title
Before / After
Open questions
The old docs previously linked to a winit but that was preventing transparency for working on Windows 11. The recent winit upgrade should have fixed this.I'm unable to test on Windows 11 though, so someone should verify that we no longer need to call this out as being broken.edit: Seems like we're good on Windows 11, thanks.