[Merged by Bors] - Revert thiserror version requirement to match version for all crates.#6365
Closed
LarsDu wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Revert thiserror version requirement to match version for all crates.#6365LarsDu wants to merge 1 commit intobevyengine:mainfrom
LarsDu wants to merge 1 commit intobevyengine:mainfrom
Conversation
Pietrek14
approved these changes
Oct 25, 2022
Pietrek14
added a commit
to Pietrek14/bevy
that referenced
this pull request
Oct 25, 2022
alice-i-cecile
approved these changes
Oct 25, 2022
Member
|
bors r+ |
alice-i-cecile
added
C-Dependencies
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
…#6365) # Objective - Reverts unnecessary version increase for `thiserror` caused by the following PR. 9066d51 - The aforementioned PR should have increased `thiserrror` version uniformly across all bevy crates. As far as I can tell it was unneccessary to bump versions ## Solution - Revert versions to the matching version used by other bevy "crates" ``` MBP-Larry-Du.local:~/Code/bevy:$ git grep thiserror CHANGELOG.md:- [Derive thiserror::Error for HexColorError][2740] crates/bevy_asset/Cargo.toml:thiserror = "1.0" crates/bevy_asset/src/asset_server.rs:use thiserror::Error; crates/bevy_asset/src/io/mod.rs:use thiserror::Error; crates/bevy_gltf/Cargo.toml:thiserror = "1.0" crates/bevy_gltf/src/loader.rs:use thiserror::Error; crates/bevy_input/Cargo.toml:thiserror = "1.0" crates/bevy_input/src/gamepad.rs:use thiserror::Error; crates/bevy_reflect/Cargo.toml:thiserror = "1.0" crates/bevy_reflect/src/path.rs:use thiserror::Error; crates/bevy_render/Cargo.toml:thiserror = "1.0" ``` --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - What changed as a result of this PR? Fixed dependency conflict for building projects. Current build of StarRust runs successfully with the `thiserror` reversion: https://github.com/LarsDu/StarRust But will run into dependency conflicts if `thiserror` is version 1.037 Co-authored-by: Larry Du <larry.du@freenome.com>
Member
|
I'd be happy to bump these requirements later, but you're right that it should be done all at once |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Contributor
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…bevyengine#6365) # Objective - Reverts unnecessary version increase for `thiserror` caused by the following PR. bevyengine@9066d51 - The aforementioned PR should have increased `thiserrror` version uniformly across all bevy crates. As far as I can tell it was unneccessary to bump versions ## Solution - Revert versions to the matching version used by other bevy "crates" ``` MBP-Larry-Du.local:~/Code/bevy:$ git grep thiserror CHANGELOG.md:- [Derive thiserror::Error for HexColorError][2740] crates/bevy_asset/Cargo.toml:thiserror = "1.0" crates/bevy_asset/src/asset_server.rs:use thiserror::Error; crates/bevy_asset/src/io/mod.rs:use thiserror::Error; crates/bevy_gltf/Cargo.toml:thiserror = "1.0" crates/bevy_gltf/src/loader.rs:use thiserror::Error; crates/bevy_input/Cargo.toml:thiserror = "1.0" crates/bevy_input/src/gamepad.rs:use thiserror::Error; crates/bevy_reflect/Cargo.toml:thiserror = "1.0" crates/bevy_reflect/src/path.rs:use thiserror::Error; crates/bevy_render/Cargo.toml:thiserror = "1.0" ``` --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - What changed as a result of this PR? Fixed dependency conflict for building projects. Current build of StarRust runs successfully with the `thiserror` reversion: https://github.com/LarsDu/StarRust But will run into dependency conflicts if `thiserror` is version 1.037 Co-authored-by: Larry Du <larry.du@freenome.com>
Pietrek14
added a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…bevyengine#6365) # Objective - Reverts unnecessary version increase for `thiserror` caused by the following PR. bevyengine@9066d51 - The aforementioned PR should have increased `thiserrror` version uniformly across all bevy crates. As far as I can tell it was unneccessary to bump versions ## Solution - Revert versions to the matching version used by other bevy "crates" ``` MBP-Larry-Du.local:~/Code/bevy:$ git grep thiserror CHANGELOG.md:- [Derive thiserror::Error for HexColorError][2740] crates/bevy_asset/Cargo.toml:thiserror = "1.0" crates/bevy_asset/src/asset_server.rs:use thiserror::Error; crates/bevy_asset/src/io/mod.rs:use thiserror::Error; crates/bevy_gltf/Cargo.toml:thiserror = "1.0" crates/bevy_gltf/src/loader.rs:use thiserror::Error; crates/bevy_input/Cargo.toml:thiserror = "1.0" crates/bevy_input/src/gamepad.rs:use thiserror::Error; crates/bevy_reflect/Cargo.toml:thiserror = "1.0" crates/bevy_reflect/src/path.rs:use thiserror::Error; crates/bevy_render/Cargo.toml:thiserror = "1.0" ``` --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - What changed as a result of this PR? Fixed dependency conflict for building projects. Current build of StarRust runs successfully with the `thiserror` reversion: https://github.com/LarsDu/StarRust But will run into dependency conflicts if `thiserror` is version 1.037 Co-authored-by: Larry Du <larry.du@freenome.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
thiserrorcaused by the following PR. 9066d51thiserrrorversion uniformly across all bevy crates. As far as I can tell it was unneccessary to bump versionsSolution
Changelog
Current build of StarRust runs successfully with the
thiserrorreversion: https://github.com/LarsDu/StarRustBut will run into dependency conflicts if
thiserroris version 1.037