[Merged by Bors] - Expose rodio's Source and Sample traits in bevy_audio#6374
Closed
elbertronnie wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Expose rodio's Source and Sample traits in bevy_audio#6374elbertronnie wants to merge 2 commits intobevyengine:mainfrom
elbertronnie wants to merge 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-Audio
Member
|
@harudagondi for review. |
alice-i-cecile
approved these changes
Oct 26, 2022
Member
|
@elbertronnie CI is failing as the file needs to be formatted :) I personally use format-on-save, but you can also use the |
alice-i-cecile
approved these changes
Oct 26, 2022
harudagondi
approved these changes
Oct 27, 2022
Member
harudagondi
left a comment
harudagondi
left a comment
There was a problem hiding this comment.
Running cargo doc and checking the page looks good to me.
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
# Objective - Fixes #5876 . ## Solution - added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample. - rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.
Contributor
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Fixes bevyengine#5876 . ## Solution - added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample. - rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#5876 . ## Solution - added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample. - rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution