[Merged by Bors] - Add multi draw indirect draw calls#6392
Closed
PixelDust22 wants to merge 3 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add multi draw indirect draw calls#6392PixelDust22 wants to merge 3 commits intobevyengine:mainfrom
PixelDust22 wants to merge 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-Rendering
IceSentry
approved these changes
Oct 28, 2022
vacuus
reviewed
Oct 28, 2022
| .multi_draw_indirect(indirect_buffer, indirect_offset, count); | ||
| } | ||
|
|
||
| /// Disptaches multiple draw calls from the active vertex buffer(s) based on the contents of the `indirect_buffer`. |
vacuus
reviewed
Oct 28, 2022
Comment on lines
+322
to
+323
| /// The indirect buffer must be long enough to account for `max_count` draws, however only `count` will | ||
| /// draws will be read. If `count` is greater than `max_count`, `max_count` will be used. |
There was a problem hiding this comment.
What does count refer to? Draws are issued; "draws will be read" is inconsistent. I want to fold the second sentence into the first; maybe "...however, only count draws, capped by max_count, will be issued". I don't like the use of "only" there.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
# Objective - Allows bevy users to dispatch `multi_draw_indirect`, `multi_draw_indexed_indirect`, `multi_draw_indirect_count`, `multi_draw_indexed_indirect_count` draw calls. - Fixes #6216 ## Solution - Added the corresponding wrapper methods to `TrackedRenderPass` --- ## Changelog > Added `multi_draw_*` draw calls to `TrackedRenderPass` Co-authored-by: Zhixing Zhang <me@neoto.xin>
Contributor
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Allows bevy users to dispatch `multi_draw_indirect`, `multi_draw_indexed_indirect`, `multi_draw_indirect_count`, `multi_draw_indexed_indirect_count` draw calls. - Fixes bevyengine#6216 ## Solution - Added the corresponding wrapper methods to `TrackedRenderPass` --- ## Changelog > Added `multi_draw_*` draw calls to `TrackedRenderPass` Co-authored-by: Zhixing Zhang <me@neoto.xin>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
multi_draw_indirect,multi_draw_indexed_indirect,multi_draw_indirect_count,multi_draw_indexed_indirect_countdraw calls.wgpu::RenderPassdraw APIs toRenderCommands #6216Solution
TrackedRenderPassChangelog