[Merged by Bors] - Add FromReflect for Visibility#6410
Closed
Shatur wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Add FromReflect for Visibility#6410Shatur wants to merge 1 commit intobevyengine:mainfrom
Shatur wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Usability
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
How does FromReflect work for Parent/Children? Doesn't it assume a default value? What does this open up?
I'm also a bit reluctant to add this for those because it allows a way to construct those types (even if it's obviously kinda overwrought), which people could abuse to create a malformed hierarchy.
No comments about the Visibility impl; I would merge that as trivial.
Contributor
Author
If I understand correctly, It creates a "default" values using |
Member
|
Yeah, remove those for now, we can add them later if needed. |
Contributor
Author
|
Okay, done! |
tim-blackbird
approved these changes
Oct 29, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2022
# Objective - `Visibility` don't have `FromReflect` derive. ## Solution - Add it. --- ## Changelog ### Added - `FromReflect` for `Visibility`.
Contributor
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - `Visibility` don't have `FromReflect` derive. ## Solution - Add it. --- ## Changelog ### Added - `FromReflect` for `Visibility`.
alice-i-cecile
added
A-ECS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Visibilitydon't haveFromReflectderive.Solution
Changelog
Added
FromReflectforVisibility.