[Merged by Bors] - Removed web-sys from bevy_window, never used#6414
Closed
slyedoc wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Removed web-sys from bevy_window, never used#6414slyedoc wants to merge 2 commits intobevyengine:mainfrom
slyedoc wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
reviewed
Oct 29, 2022
Co-authored-by: François <mockersf@gmail.com>
alice-i-cecile
approved these changes
Oct 29, 2022
alice-i-cecile
added
the
C-Dependencies
Member
|
Thanks! |
mockersf
approved these changes
Oct 29, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2022
# Objective Noticed bevy_window doesn't ever use web-sys. That logic resides to bevy_winit and winit. ## Solution Remove web-sys dependency
Contributor
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Noticed bevy_window doesn't ever use web-sys. That logic resides to bevy_winit and winit. ## Solution Remove web-sys dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Noticed bevy_window doesn't ever use web-sys.
That logic resides to bevy_winit and winit.
Solution
Remove web-sys dependency