Skip to content

[Merged by Bors] - Add FromReflect for Timer#6422

Closed
Shatur wants to merge 1 commit intobevyengine:mainfrom
simgine:from-reflect-timer
Closed

[Merged by Bors] - Add FromReflect for Timer#6422
Shatur wants to merge 1 commit intobevyengine:mainfrom
simgine:from-reflect-timer

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 30, 2022

Objective

  • Time have Reflect, but doesn't have FromReflect.

Solution

  • Add it for Timer, Stopwatch and TimerMode.

Changelog

Added

  • FromReflect derive for Timer, Stopwatch and TimerMode.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Time Involves time keeping and reporting S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it hacktoberfest-accepted and removed hacktoberfest-accepted labels Oct 30, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Oct 30, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 30, 2022
@Shatur
Add FromReflect for Timer (#6422)
7540328 
# Objective

- Time have `Reflect`, but doesn't have `FromReflect`.

## Solution

- Add it for `Timer`, `Stopwatch` and `TimerMode`.

---

## Changelog

### Added

* `FromReflect` derive for `Timer`, `Stopwatch` and `TimerMode`.
@bors
Copy link
Contributor

bors bot commented Oct 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add FromReflect for Timer [Merged by Bors] - Add FromReflect for Timer Oct 30, 2022
@bors bors bot closed this Oct 30, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Shatur @ItsDoot
Add FromReflect for Timer (bevyengine#6422)
a069186 
# Objective

- Time have `Reflect`, but doesn't have `FromReflect`.

## Solution

- Add it for `Timer`, `Stopwatch` and `TimerMode`.

---

## Changelog

### Added

* `FromReflect` derive for `Timer`, `Stopwatch` and `TimerMode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Time Involves time keeping and reporting C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Reflection (Old)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Shatur @alice-i-cecile @tim-blackbird @MrGVSV @mockersf