[Merged by Bors] - Remove auto-margin properties from the examples#6535
Closed
garychia wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Remove auto-margin properties from the examples#6535garychia wants to merge 1 commit intobevyengine:mainfrom
garychia wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-UI
Member
|
Awesome, thank you very much! |
TimJentzsch
approved these changes
Nov 10, 2022
Contributor
TimJentzsch
left a comment
TimJentzsch
left a comment
There was a problem hiding this comment.
Definitely a bit more verbose, but this should be the correct way to do this.
Maybe we can introduce some helper methods in the future that make common stuff like this easier.
Weibye
approved these changes
Nov 11, 2022
Contributor
Weibye
left a comment
Weibye
left a comment
There was a problem hiding this comment.
Ran all relevant examples and verified that they look the same 👍
Weibye
added
the
S-Ready-For-Final-Review
Member
|
@garychia hit merge conflicts, sorry! Can you resolve these? |
garychia
force-pushed
the
remove-auto-margin
branch
from
3de0dea to
938fb93
Compare
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 21, 2022
# Objective Fixes #6498. ## Solution Adding a parent node with properties AlignItems::Center and JustifyContent::Center to centered child nodes and removing their auto-margin properties.
Contributor
bors
bot
changed the title
taiyoungjang
pushed a commit
to taiyoungjang/bevy
that referenced
this pull request
Dec 15, 2022
# Objective Fixes bevyengine#6498. ## Solution Adding a parent node with properties AlignItems::Center and JustifyContent::Center to centered child nodes and removing their auto-margin properties.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective Fixes bevyengine#6498. ## Solution Adding a parent node with properties AlignItems::Center and JustifyContent::Center to centered child nodes and removing their auto-margin properties.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#6498. ## Solution Adding a parent node with properties AlignItems::Center and JustifyContent::Center to centered child nodes and removing their auto-margin properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6498.
Solution
Adding a parent node with properties AlignItems::Center and JustifyContent::Center to centered child nodes and removing their auto-margin properties.