[Merged by Bors] - Update old docs from Timer#6646
Closed
edgarssilva wants to merge 2 commits intobevyengine:mainfrom
edgarssilva:patch-1
Closed
[Merged by Bors] - Update old docs from Timer#6646edgarssilva wants to merge 2 commits intobevyengine:mainfrom edgarssilva:patch-1
edgarssilva wants to merge 2 commits intobevyengine:mainfrom
edgarssilva:patch-1
Conversation
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`. When switching from the old `is_repeating()` and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
alice-i-cecile
added
C-Docs
Pietrek14
approved these changes
Nov 17, 2022
hymm
approved these changes
Nov 17, 2022
hymm
added
the
S-Ready-For-Final-Review
Member
|
a doc alias to "repeating" count be nice too 👍 |
Contributor
Author
Added a small commit, not sure if that's intended since it's my first time writing docs in rust and contributing to bevy. |
mockersf
approved these changes
Nov 18, 2022
Member
There was a problem hiding this comment.
good for me, let's see what @alice-i-cecile thinks 🙂
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`. When switching from the old `is_repeating()` and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
Contributor
bors
bot
changed the title
taiyoungjang
pushed a commit
to taiyoungjang/bevy
that referenced
this pull request
Dec 15, 2022
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`. When switching from the old `is_repeating()` and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`. When switching from the old `is_repeating()` and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`. When switching from the old `is_repeating()` and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the
TimerMode. When switching from the oldis_repeating()andset_repeating()to the newmode()andset_mode()noticed the docs still had the old description.