Skip to content

Fix breakout example bug - ball flighlying out when collide paddle and wall at the same time #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cart merged 2 commits into from
Oct 15, 2020
Merged

Fix breakout example bug - ball flighlying out when collide paddle and wall at the same time #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e13cff3
Fix breakout bug - ball flighlying out when colide paddle and wall
Oct 15, 2020
9314fc9
Minor fixup - address PR input
Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions examples/game/breakout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ struct Scoreboard {
enum Collider {
Solid,
Scorable,
Paddle,
}

fn setup(
Expand All @@ -53,7 +54,7 @@ fn setup(
..Default::default()
})
.with(Paddle { speed: 500.0 })
.with(Collider::Solid)
.with(Collider::Paddle)
// ball
.spawn(SpriteComponents {
material: materials.add(Color::rgb(1.0, 0.5, 0.5).into()),
Expand Down Expand Up @@ -240,7 +241,10 @@ fn ball_collision_system(
*velocity.y_mut() = -velocity.y();
}

break;
// break if this collide is on a solid, otherwise continue check whether a solid is also in collision
if let Collider::Solid = *collider {
break;
}
}
}
}
Expand Down