assets.get can take any kind of handle#6948
Closed
mockersf wants to merge 1 commit intobevyengine:mainfrom
Closed
Conversation
ecbf158 to
5d93974
Compare
MrGVSV
approved these changes
Dec 14, 2022
HoNile
suggested changes
Dec 14, 2022
HoNile
left a comment
There was a problem hiding this comment.
Good but if get change I think get_mut should do the same, and I guess contains too.
Contributor
|
I'm not sure about this. This removes a type check that prevents Then again, a lot of the other methods already take |
Contributor
|
Yeah, I'm with ira on that one, the typecheck seems valuable here. |
Member
|
Doesn't HandleId carry type/asset path information in it already? If we pass a |
Contributor
|
It was actually changed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
assets.getcan take anHandle<T>or anHandleIdSolution
HandleIdanyway, so just expose it as needing the trait