[Merged by Bors] - Relax Sync bound on Local<T> as ExclusiveSystemParam#7040
Closed
joseph-gio wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Relax Sync bound on Local<T> as ExclusiveSystemParam#7040joseph-gio wants to merge 2 commits intobevyengine:mainfrom
Sync bound on Local<T> as ExclusiveSystemParam#7040joseph-gio wants to merge 2 commits intobevyengine:mainfrom
Conversation
joseph-gio
added
A-ECS
alice-i-cecile
approved these changes
Dec 27, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
This is surprisingly useful!
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Dec 27, 2022
tim-blackbird
approved these changes
Dec 27, 2022
Member
|
bors r+ |
Contributor
|
Merge conflict. |
Member
Author
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
# Objective The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system. ## Solution Lift the bound. --- ## Changelog Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Sync bound on Local<T> as ExclusiveSystemParamSync bound on Local<T> as ExclusiveSystemParam
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jan 21, 2023
…7040) # Objective The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system. ## Solution Lift the bound. --- ## Changelog Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
…7040) # Objective The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system. ## Solution Lift the bound. --- ## Changelog Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…7040) # Objective The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system. ## Solution Lift the bound. --- ## Changelog Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The type
Local<T>unnecessarily has the boundT: Syncwhen the local is used in an exclusive system.Solution
Lift the bound.
Changelog
Removed the bound
T: SyncfromLocal<T>when used as anExclusiveSystemParam.