[Merged by Bors] - improve nix docs#7044
Closed
figsoda wants to merge 1 commit intobevyengine:mainfrom
figsoda:docs
Closed
[Merged by Bors] - improve nix docs#7044figsoda wants to merge 1 commit intobevyengine:mainfrom figsoda:docs
figsoda wants to merge 1 commit intobevyengine:mainfrom
figsoda:docs
Conversation
alice-i-cecile
added
C-Docs
alice-i-cecile
approved these changes
Dec 28, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
LGTM. As is conventional for this file, this is basically a "this is clear and free of obvious mistakes" not, "I have verified this personally" :)
Member
|
I do, however, find it exceptionally alarming that Nix(OS) has been updated at this cadence. Not sure what is going on, but the rate at which these edits are coming seems to outpace even the dependency churn rate for Bevy as a whole. |
SuperSandro2000
approved these changes
Dec 28, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
kristoff3r
approved these changes
Dec 29, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
# Objective `xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements ## Solution - rename NixOS to Nix since this is not specific to NixOS - remove usage of `xlibsWrapper` - add instructions for nix flakes with `nix develop` - add example of a packaged bevy program in nixpkgs - minor cosmetic/grammatical changes
Contributor
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective `xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements ## Solution - rename NixOS to Nix since this is not specific to NixOS - remove usage of `xlibsWrapper` - add instructions for nix flakes with `nix develop` - add example of a packaged bevy program in nixpkgs - minor cosmetic/grammatical changes
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements ## Solution - rename NixOS to Nix since this is not specific to NixOS - remove usage of `xlibsWrapper` - add instructions for nix flakes with `nix develop` - add example of a packaged bevy program in nixpkgs - minor cosmetic/grammatical changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
xlibsWrapperis being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvementsSolution
xlibsWrappernix develop