[Merged by Bors] - Fix doc in App::add_sub_app#7139
Closed
2ne1ugly wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix doc in App::add_sub_app#71392ne1ugly wants to merge 1 commit intobevyengine:mainfrom
App::add_sub_app#71392ne1ugly wants to merge 1 commit intobevyengine:mainfrom
Conversation
2ne1ugly
force-pushed
the
fix-add-sub-app-doc
branch
from
0a8d61d to
10478a3
Compare
2ne1ugly
force-pushed
the
fix-add-sub-app-doc
branch
from
10478a3 to
cf03048
Compare
james7132
approved these changes
Jan 9, 2023
james7132
added
A-App
bors bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
# Objective - Fix the name of function parameter name in docs ## Solution - Change `f` to `sub_app_runner` --- It confused me a bit when I was reading the docs in the autocomplete hint. Hesitated about filing a PR since it's just a one single word change in the comment. Is this the right process to change these docs?
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
# Objective - Fix the name of function parameter name in docs ## Solution - Change `f` to `sub_app_runner` --- It confused me a bit when I was reading the docs in the autocomplete hint. Hesitated about filing a PR since it's just a one single word change in the comment. Is this the right process to change these docs?
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
App::add_sub_appApp::add_sub_app
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jan 21, 2023
# Objective - Fix the name of function parameter name in docs ## Solution - Change `f` to `sub_app_runner` --- It confused me a bit when I was reading the docs in the autocomplete hint. Hesitated about filing a PR since it's just a one single word change in the comment. Is this the right process to change these docs?
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - Fix the name of function parameter name in docs ## Solution - Change `f` to `sub_app_runner` --- It confused me a bit when I was reading the docs in the autocomplete hint. Hesitated about filing a PR since it's just a one single word change in the comment. Is this the right process to change these docs?
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fix the name of function parameter name in docs ## Solution - Change `f` to `sub_app_runner` --- It confused me a bit when I was reading the docs in the autocomplete hint. Hesitated about filing a PR since it's just a one single word change in the comment. Is this the right process to change these docs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
ftosub_app_runnerIt confused me a bit when I was reading the docs in the autocomplete hint.
Hesitated about filing a PR since it's just a one single word change in the comment.
Is this the right process to change these docs?