Moved UI widgets to a bevy_widget crate#7197
Moved UI widgets to a bevy_widget crate#7197Pietrek14 wants to merge 52 commits intobevyengine:mainfrom
bevy_widget crate#7197Conversation
Co-authored-by: Mike <mike.hsu@gmail.com>
crates/bevy_widget/src/lib.rs
Outdated
| @@ -0,0 +1,12 @@ | |||
| mod widget; | |||
There was a problem hiding this comment.
Can you add forbid(unsafe_code) and warn(missing_docs) crate level rules please?
Once that's in, we should add basic doc strings.
There was a problem hiding this comment.
The only thing with missing docs is QueuedText. It's only used as a Local for text_system, so should we even keep it public?
There was a problem hiding this comment.
We should probably keep text_system public, so we need to keep the Local type public or Rust will complain.
|
Marked as Controversial since this adds a new crate, but it seems like there's pretty clear consensus on splitting apart the code like this. |
alice-i-cecile
left a comment
There was a problem hiding this comment.
Feedback on structure:
- I think that the widget bundles belong in the same file as the logic for that widget.
- I don't think that the
widgetmodule is useful since we're in a dedicated crate for widgets. We can just make each widget a top level module.
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
left a comment
There was a problem hiding this comment.
LGTM now :) I trust that you'll get basic docs for QueuedText working.
…anch 'main' of https://github.com/bevyengine/bevy into widget-plugin
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
1 similar comment
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
1 similar comment
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
|
I don't mean to rush anything, but how long may it take for this PR to reach Cart's attention? There are merge conflicts to resolve every time any change is made to the |
|
Disclaimer: I'm not Cart I think it's too early to do this, and I haven't seen either in this PR or in the issue it fixes a good enough justification for the change. This is just a code organisation changes that doesn't improve anything or unlock anything, as such it's very low priority |
|
You added a new example but didn't update the readme. Please run |
|
You added a new example but didn't update the readme. Please run |
|
Backlog cleanup: closing due to inactivity. We've already split out a number of crates, so I guess there's nothing to stop us doing this later but probably easier to begin again after 0.15. |
|
I still think we should do something like this, but yeah, this requires consensus and broad maintainer buy-in :( |
|
I hovered over the button, but figured someone would yell if they really wanted it kept! |
Objective
Fixes #7190.
Solution
bevy_widgetcrate to BevyChangelog
bevy_widgetcrateWidgetPluginbevy_widgetcrateMigration Guide
widgetmodule instead ofuibevy_widgetfeature flagWidgetPluginto your app