Temporal Antialiasing (TAA)#7291
Merged
superdump merged 392 commits intobevyengine:mainfrom Mar 27, 2023
Merged
Conversation
This reverts commit 49af70d.
superdump
requested changes
Mar 26, 2023
| HandleUntyped::weak_from_u64(Shader::TYPE_UUID, 656865235226276); | ||
|
|
||
| /// Plugin for temporal antialiasing. Disables multisample antialiasing (MSAA). | ||
| pub struct TemporalAntialiasPlugin; |
Contributor
There was a problem hiding this comment.
I agree with others here, it should be TemporalAntiAlias.
Comment on lines
+7
to
+8
| const HISTORY_BLEND_RATE: f32 = 0.1; | ||
| const MIN_HISTORY_BLEND_RATE: f32 = 0.015; |
Contributor
There was a problem hiding this comment.
From where do these come? And what do they mean?
Contributor
Author
There was a problem hiding this comment.
I made it up, and decided on these values through trial and error. I'll add some docs.
Contributor
There was a problem hiding this comment.
I did see mention of 90% / 10% somewhere, but the MIN_HISTORY_BLEND_RATE value I don't know.
Co-authored-by: Robert Swain <robert.swain@gmail.com>
superdump
requested changes
Mar 26, 2023
Co-authored-by: Robert Swain <robert.swain@gmail.com>
Co-authored-by: Robert Swain <robert.swain@gmail.com>
superdump
approved these changes
Mar 27, 2023
Contributor
superdump
left a comment
There was a problem hiding this comment.
I think this meets the bar. Thanks for implementing this in the first place, and for your patience waiting for review. :)
robtfm
approved these changes
Mar 27, 2023
This was referenced Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Followup Work
Changelog