[Merged by Bors] - Fix a few uninlined_format_args lints#7368
Closed
rparrett wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix a few uninlined_format_args lints#7368rparrett wants to merge 2 commits intobevyengine:mainfrom
rparrett wants to merge 2 commits intobevyengine:mainfrom
Conversation
james7132
approved these changes
Jan 26, 2023
james7132
added
C-Code-Quality
tim-blackbird
approved these changes
Jan 26, 2023
Contributor
tim-blackbird
left a comment
tim-blackbird
left a comment
There was a problem hiding this comment.
CI is currently blocked on this :p
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
# Objective Prevent things from breaking tomorrow when rust 1.67 is released. ## Solution Fix a few `uninlined_format_args` lints in recently introduced code.
Contributor
|
Build failed: |
Member
|
There seems to be one missed one in |
Contributor
Author
|
Got it. That example was added after this PR. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
# Objective Prevent things from breaking tomorrow when rust 1.67 is released. ## Solution Fix a few `uninlined_format_args` lints in recently introduced code.
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Prevent things from breaking tomorrow when rust 1.67 is released. ## Solution Fix a few `uninlined_format_args` lints in recently introduced code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Prevent things from breaking tomorrow when rust 1.67 is released.
Solution
Fix a few
uninlined_format_argslints in recently introduced code.