Make ComponentTicks available from ChangeTrackers#7410
Closed
chrisjuchem wants to merge 1 commit intobevyengine:mainfrom
Closed
Make ComponentTicks available from ChangeTrackers#7410chrisjuchem wants to merge 1 commit intobevyengine:mainfrom
chrisjuchem wants to merge 1 commit intobevyengine:mainfrom
Conversation
Member
|
It feels like the |
Contributor
Author
|
Makes sense, I'll move it there. |
Member
|
FYI, type ChangedComponetsQuery<'w, 's, T> = Query<
'w,
's,
(
Entity,
// TODO: Figure out if the static lifetime is right here
&'static <T as IndexInfo>::Component,
ChangeTrackers<<T as IndexInfo>::Component>,
),
>;Would become this: type ChangedComponetsQuery<'w, 's, T> = Query<
'w,
's,
(
Entity,
Ref<'static, <T as IndexInfo>::Component>,
),
>;Also: the static lifetime is indeed correct here. The lifetimes bound to |
Contributor
Author
|
Thank you for the pointers @JoJoJet. It turns out that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
To implement indexes, I need to be able to check if a component has changed since an arbitrary time, not just since the last time the system ran.
Solution
Allow for getting a read only reference to
ComponentTicksfromChangeTrackersso thatComponentTicks::is_addedandComponentTicks::is_changedcan be used, since they take thelast_change_tickas a parameter.Alternatives
Implement
is_added_sinceandis_changed_sinceonChangeTrackersitself, deferring toComponentTicksunder the hood.Changelog
ticksmethod toChangeTrackersto get theComponentTickstracking when a component was added/changed.