[Merged by Bors] - Changed &mut PipelineCache to &PipelineCache#7598
Closed
kurtkuehnert wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Changed &mut PipelineCache to &PipelineCache#7598kurtkuehnert wants to merge 1 commit intobevyengine:mainfrom
kurtkuehnert wants to merge 1 commit intobevyengine:mainfrom
Conversation
james7132
added
A-Rendering
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
james7132
approved these changes
Feb 10, 2023
Pietrek14
approved these changes
Feb 10, 2023
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
This was missed in #7205. Should be fixed now. 😄 ## Migration Guide - `SpecializedComputePipelines::specialize` now takes a `&PipelineCache` instead of a `&mut PipelineCache`
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 11, 2023
This was missed in bevyengine#7205. Should be fixed now. 😄 ## Migration Guide - `SpecializedComputePipelines::specialize` now takes a `&PipelineCache` instead of a `&mut PipelineCache`
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 11, 2023
This was missed in bevyengine#7205. Should be fixed now. 😄 ## Migration Guide - `SpecializedComputePipelines::specialize` now takes a `&PipelineCache` instead of a `&mut PipelineCache`
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
This was missed in bevyengine#7205. Should be fixed now. 😄 ## Migration Guide - `SpecializedComputePipelines::specialize` now takes a `&PipelineCache` instead of a `&mut PipelineCache`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in #7205.
Should be fixed now. 😄
Migration Guide
SpecializedComputePipelines::specializenow takes a&PipelineCacheinstead of a&mut PipelineCache