[Merged by Bors] - don't require features on examples where it's not the main focus#7615
Closed
mockersf wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - don't require features on examples where it's not the main focus#7615mockersf wants to merge 2 commits intobevyengine:mainfrom
mockersf wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
added
A-Rendering
alice-i-cecile
approved these changes
Feb 10, 2023
IceSentry
approved these changes
Feb 11, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
JMS55
approved these changes
Feb 11, 2023
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Objective - Required features were added to some examples in #7051 even though those features aren't the main focus of the examples - Don't require features on examples that are useful without them ## Solution - Remove required features on examples `load_gltf` and `scene_viewer`, but log a warning when they are not enabled
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 14, 2023
…yengine#7615) # Objective - Required features were added to some examples in bevyengine#7051 even though those features aren't the main focus of the examples - Don't require features on examples that are useful without them ## Solution - Remove required features on examples `load_gltf` and `scene_viewer`, but log a warning when they are not enabled
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
…yengine#7615) # Objective - Required features were added to some examples in bevyengine#7051 even though those features aren't the main focus of the examples - Don't require features on examples that are useful without them ## Solution - Remove required features on examples `load_gltf` and `scene_viewer`, but log a warning when they are not enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
load_gltfandscene_viewer, but log a warning when they are not enabled