UiRect axes constructor

[ickshonpe]

Objective

We don't have a constructor function for UiRect that sets uniform horizontal and vertical values, even though it is a common pattern.

Solution

Add a constructor function to UiRect called axes, that sets both left and right to the same given horizontal value,
and sets both top and bottom to same given vertical value.

Changelog

• Added a constructor function axes to UiRect.

[alice-i-cecile]

LGTM but I'm similarly unhappy with that name.

uniform_axes is better, but not great. xy is very terse but not super clear. paired_axes or matching_axes isn't any better.

What about UiRect::symmetric(horizontal, vertical)?

[ickshonpe]

I'm not sure about symmetric either, it might not be very intuitive to people without a maths background.

[ickshonpe]

Part of the problem is like UiRect isn't even used to represent rectangles, but renaming it to RetangularAnnulus is never going to fly.

[alice-i-cecile]

renaming it to RetangularAnnulus is never going to fly.

#shipit 🚀 🚀 😎

Can we split out the different uses of UiRect? It's always felt like we're punning on the fact that the data can be represented in the same way, even though the semantic meaning of "rectangle" vs "annulus" is very different.

RectRing perhaps?

[SDesya74]

RectRing perhaps?

I also recently thought that the the name does not describe what the UiRect is. Perhaps the word Borders is appropriate?

[ickshonpe]

I really hate the name axis, axis is singular not plural 😞

Maybe axes is a good enough compromise? It at least isn't likely to get confused with anything else.

[SDesya74]

I like axes, word has the same length, but I'm not so familiar with English to speak with confidence

[ickshonpe]

RectRing perhaps?

I also recently thought that the the name does not describe what the UiRect is. Perhaps the word Borders is appropriate?

I thought about the name Frame. UiRect is used for a lot of very different things though. It would be really weird to have the type used to represent positions named Borders or Frame or RectRing.

Another option is to have separate types Margin, Border, Padding, Position, etc and use macros or cut and paste to implement UiRect's functions for each one.

At the moment the UiRect docs are a bit confusing, with different sections for each different property it can represent.
If it was split up, there could be longer docs for each property explaining in detail how to use each one.

[alice-i-cecile]

I like axes as well for the name of this constructor method.

As for the type question, I like Frame quite a bit, and would support a PR renaming UiRect to that. Splitting the types is also very appealing.

[ickshonpe]

Definitely axes.

[ickshonpe]

This is ready to be merged I think.