[Merged by Bors] - Fix trait bounds for run conditions#7688
Closed
joseph-gio wants to merge 5 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix trait bounds for run conditions#7688joseph-gio wants to merge 5 commits intobevyengine:mainfrom
joseph-gio wants to merge 5 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Feb 15, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
# Objective The trait `Condition<>` is implemented for any type that can be converted into a `ReadOnlySystem` which takes no inputs and returns a bool. However, due to the current implementation, consumers of the trait cannot rely on the fact that `<T as Condition>::System` implements `ReadOnlySystem`. In cases such as the `not` combinator (added in #7559), we are required to add redundant `T::System: ReadOnlySystem` trait bounds, even though this should be implied by the `Condition<>` trait. ## Solution Add a hidden associated type which allows the compiler to figure out that the `System` associated type implements `ReadOnlySystem`.
Contributor
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 16, 2023
# Objective The trait `Condition<>` is implemented for any type that can be converted into a `ReadOnlySystem` which takes no inputs and returns a bool. However, due to the current implementation, consumers of the trait cannot rely on the fact that `<T as Condition>::System` implements `ReadOnlySystem`. In cases such as the `not` combinator (added in bevyengine#7559), we are required to add redundant `T::System: ReadOnlySystem` trait bounds, even though this should be implied by the `Condition<>` trait. ## Solution Add a hidden associated type which allows the compiler to figure out that the `System` associated type implements `ReadOnlySystem`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The trait
Condition<>is implemented for any type that can be converted into aReadOnlySystemwhich takes no inputs and returns a bool. However, due to the current implementation, consumers of the trait cannot rely on the fact that<T as Condition>::SystemimplementsReadOnlySystem. In cases such as thenotcombinator (added in #7559), we are required to add redundantT::System: ReadOnlySystemtrait bounds, even though this should be implied by theCondition<>trait.Solution
Add a hidden associated type which allows the compiler to figure out that the
Systemassociated type implementsReadOnlySystem.