Inline "small" systems into the multithreaded executor#7693
Closed
james7132 wants to merge 1 commit intobevyengine:mainfrom
Closed
Inline "small" systems into the multithreaded executor#7693james7132 wants to merge 1 commit intobevyengine:mainfrom
james7132 wants to merge 1 commit intobevyengine:mainfrom
Conversation
Member
Author
|
With #11906 now running the multithreaded executor immediately after every system, we can achieve similar results without needing to inline the systems. I've also come to realize that running systems inline is likely an all around bad practice given that it potentially blocks starting new systems even without a strict before/after relationship, and that's a huge risk in any cooperative task scheduler. Closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Minimize overhead from scheduling large numbers of systems with very little work to do. Partially address #7208.
Solution
Keep a exponential moving average for how long it takes to run each system. If a system has historically run in under 2 microseconds, run it inside the multithreaded executor.
The threshold is currently hard-coded and is rather conservative to avoid potentially inlining too many systems and forcing it large sections to run single threaded.
TODO:
Performance
TODO