[Merged by Bors] - IntoIterator for EventReader#7720
Closed
Aceeri wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - IntoIterator for EventReader#7720Aceeri wants to merge 1 commit intobevyengine:mainfrom
Aceeri wants to merge 1 commit intobevyengine:mainfrom
Conversation
Aceeri
added
A-ECS
alice-i-cecile
approved these changes
Feb 16, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
Merging as trivial. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# Objective Continuation of #5719 Now that we have a definable type for the iterator. --- ## Changelog - Implemented IntoIterator for EventReader so you can now do `&mut reader` instead of `reader.iter()` for events.
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# Objective Continuation of #5719 Now that we have a definable type for the iterator. --- ## Changelog - Implemented IntoIterator for EventReader so you can now do `&mut reader` instead of `reader.iter()` for events.
Contributor
|
Already running a review |
Contributor
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
# Objective Continuation of bevyengine#5719 Now that we have a definable type for the iterator. --- ## Changelog - Implemented IntoIterator for EventReader so you can now do `&mut reader` instead of `reader.iter()` for events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Continuation of #5719
Now that we have a definable type for the iterator.
Changelog
&mut readerinstead ofreader.iter()for events.