Add TextLayoutInfo to TextBundle and Text2dBundle#7748
Closed
ickshonpe wants to merge 3 commits intobevyengine:mainfrom
Closed
Add TextLayoutInfo to TextBundle and Text2dBundle#7748ickshonpe wants to merge 3 commits intobevyengine:mainfrom
TextLayoutInfo to TextBundle and Text2dBundle#7748ickshonpe wants to merge 3 commits intobevyengine:mainfrom
Conversation
omwda
approved these changes
Feb 21, 2023
Contributor
Author
|
Closed, as this was done in #7779. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
TextBundleandText2dBundledon't haveTextLayoutInfocomponents. Instead,TextLayoutInfois inserted by theupdate_2d_layoutandtext_systemsystems. This seems to be both more complicated and marginally less efficient than just adding the component to the bundles directly.Solution
TextLayoutInfocomponent to theTextBundleandText2dBundlebundles.TextLayoutInfoqueries to non-optional.Commandsparameters and match statements.Changelog
TextLayoutInfocomponent toTextBundle.TextLayoutInfocomponent toText2dBundle.TextLayoutInfoqueries to be non-optional.Migration Guide
The
TextLayoutInfocomponent has been added toTextBundleandText2dBundle.To draw text using the text2d or ui text systems entities must have the
TextLayoutInfocomponent.